Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples bug on writing-helpers.md #112

Merged
merged 5 commits into from Jul 23, 2018

Conversation

hakilebara
Copy link
Contributor

@hakilebara hakilebara commented Jul 20, 2018

image

@sivakumar-kailasam
Copy link
Member

If it isn't too much trouble can you make the changes in 3.3, 3.1 & 3.0 docs as well?

@hakilebara
Copy link
Contributor Author

Sure, I'll need to do a proper fork then. I'll try and do it over the week-end.

@sivakumar-kailasam
Copy link
Member

FYI, a branch is already created on your fork for this PR when you edited it via the UI, so you could edit the other files there from the github ui as well. No hurry though 😄

@hakilebara
Copy link
Contributor Author

Thanks for the tip 👍 I updated the PR to include 3.3, 3.1 & 3.0 docs as well.

@hakilebara hakilebara closed this Jul 23, 2018
@hakilebara hakilebara reopened this Jul 23, 2018
@sivakumar-kailasam sivakumar-kailasam merged commit 7fe1881 into ember-learn:master Jul 23, 2018
@jenweber jenweber mentioned this pull request Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants