Skip to content

Defines what a component is and is used for #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Defines what a component is and is used for #283

merged 2 commits into from
Nov 20, 2018

Conversation

zachgarwood
Copy link
Contributor

On the Building a Simple Component page, we jump right into building a
component without defining what a component is or what they are use for.
This change adds a brief definition (the same one used in
https://guides.emberjs.com/v3.5.0/components/defining-a-component/) and
a reason why the user might want to use them.

This addresses one of the "tiny tutorial fixes" @jenweber listed
in #245.

On the Building a Simple Component page, we jump right into building a
component without defining what a component is or what they are use for.
This change adds a brief definition (the same one used in
https://guides.emberjs.com/v3.5.0/components/defining-a-component/) and
a reason why the user might want to use them.
@BradenLawrence
Copy link

This change looks good to me!

@jenweber jenweber self-requested a review November 20, 2018 03:58
@jenweber jenweber merged commit 0a5a34a into ember-learn:master Nov 20, 2018
@jenweber
Copy link
Contributor

Awesome, thank you!

@zachgarwood zachgarwood deleted the define-component branch November 26, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants