Skip to content

Conversation

mansona
Copy link
Member

@mansona mansona commented Dec 10, 2017

ember-learn/guides-app#7

This is now ready and constitutes a "good enough" approach for how we tackle this for now. I have manually reviewed all code examples in the 2.17 release and I'm happy that it is doing something sensible for all/most cases 👍

Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@mansona mansona force-pushed the feature/highlight-format branch from 4ae127e to 3eaf375 Compare January 12, 2018 13:15
@mansona mansona requested a review from a team January 12, 2018 13:15
@mansona mansona changed the title [WIP] [Discussion] updating all hbs and js file code examples to get ribbon implementation working updating all hbs and js file code examples to get ribbon implementation working Jan 12, 2018
@mansona
Copy link
Member Author

mansona commented Jan 12, 2018

btw my "manual" review was using this snippet in the chrome console 😍

function scrollToNext(index) {
  let block = document.getElementsByTagName('pre')[index];
  if(block) {
    block.scrollIntoView();

    setTimeout(() => {
      scrollToNext(index+1);
    }, 1000)
  } else {
    document.getElementsByClassName('next-guide')[0].click();
    setTimeout(() => {
      scrollToNext(0);
    }, 100)
  }
}

scrollToNext(0)

@jenweber
Copy link
Contributor

Reviewed in staging. :shipit:

@jenweber jenweber merged commit 26db2fc into master Jan 18, 2018
@mansona mansona deleted the feature/highlight-format branch January 18, 2018 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants