unify prod/dev add-on build #4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
|
|
||
| included: function(app) { | ||
| this._super.included.apply(this, arguments); | ||
|
|
||
| if (process.env.EMBER_ENV === 'production') { | ||
| add(this.options.babel, 'backlist', ['es6.modules', 'useStrict']); |
|
Did I really fuck up that spelling again... |
|
it was your heart on the line |
stefanpenner
force-pushed
the
cleanup-builds
branch
from
05e3aec
to
3364685
Compare
|
I am so confused by what is going on. Wasn't this merged already? |
|
@rwjblue nope not yet I think its good to go now, lets see what others say |
| }, | ||
|
|
||
| included: function(app) { | ||
| this._super.included.apply(this, arguments); | ||
|
|
||
| if (process.env.EMBER_ENV === 'production') { | ||
| add(this.options.babel, 'blacklist', ['es6.modules', 'useStrict']); |
There was a problem hiding this comment.
When I run npm run production the add function fails because this.options.babel is undefined.
There was a problem hiding this comment.
hmm, good catch. I admittedly have been lazy the last few updates here, sorry for not catching.
stefanpenner
force-pushed
the
cleanup-builds
branch
from
3364685
to
e1be175
Compare
|
recent changes are tested in small app + ember data builds with both --prod and not |
|
Looks good thanks @stefanpenner |
This was referenced Mar 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
force-push mistake, resurrection of #4206