[FEAT fetch] use ember-fetch instead of jQuery

[tchak]

depends on #5375, #5385 and #5375
will fix #5320

[nlfurniss]

I've been wondering where the best place for this to live is. In a jQuery-less world, $.param() is gone and Ember should have some replacement.

[tchak]

I feel like ember-fetch is good place for now. I am planing on doing a PR to move it out of ember-fetch/mixins/adapter-fetch. But a broader discussion is needed about fetch usage: fetch on it own is not a suitable replacement for $.ajax in my opinion. fetch is too low level.

[tchak]

Another option might be to use URLSearchParams provided by ember-url (with polyfills). It is a standard, but might be less convenient then a $.param().

[NullVoxPopuli]

what's better? URLSearchParams from ember-url, or serializerQueryParams from the fetch adapter?

[tchak]

Using URLSearchParams is not an option after investigation – it won't serialise nested params. I think wee should expose something like import { param } from 'ember-fetch';

[NullVoxPopuli]

ember-cli/ember-fetch#130

[NullVoxPopuli]

@tchak ember-fetch has been updated!

[btecu]

@tchak What's the status? Seems to be the last step for being able to use ED without jQuery.

[runspired]

I think we should we make this a peerDependency instead to avoid trolling folks with multiple versions, and a devDependency for our own use.

[NullVoxPopuli]

this still needs to be removed from here. this was probably my bad when I did partial work on this.

[runspired]

@tchak @NullVoxPopuli think this needs updated for code style, there's also some broken tests

[NullVoxPopuli]

I'll take a look. :)
unless @tchak is already working on it :)

[tchak]

I probably won't be available today match, but I should be able to help if needed tomorrow

[NullVoxPopuli]

copying this from the other PR:

I think there should probably be a good amount of tests for fetch, which don't exist yet.
also, with ember fetch, there is this function: mungOptionsForFetch

So, I think for this feature to be complete, we need to find all the request url / headers / whatever related tests and make fetch versions of them.

[tchak]

There is a couple of external tests failing. Ember Observer seems like a timeout. Ilios Frontend looks like some genuine errors. I will have to look in to it more closely.

[runspired]

@tchak may also be flakiness, it passed when I restarted the job. cc @jrjohnson

[jrjohnson]

I can't see the failure, but we've been struggling terribly with flaky tests the last couple of days for reasons we haven't tracked down yet. If the error was something like https://github.com/ilios/frontend/issues/4046 then this may be the issue.

[NullVoxPopuli]

build passed! (but hasn't reported back to github for some reason)

[runspired]

@NullVoxPopuli anything remaining? I noticed this:

I think there should probably be a good amount of tests for fetch, which don't exist yet.
also, with ember fetch, there is this function: mungOptionsForFetch

So, I think for this feature to be complete, we need to find all the request url / headers / whatever related tests and make fetch versions of them.

[NullVoxPopuli]

@runspired good catch --

this file: https://github.com/emberjs/data/pull/5386/files#diff-038a1249383849dd6526ee97d193e925R90

the ajax file needs a fetch equivalent.

also, are coverage artifacts outputted somewhere? my hunch is that a lot of the new fetch stuff is missing most coverage

[NullVoxPopuli]

tests and ember-fetch dep removed: tchak#3

[mansona]

@tchak I know it might seem a bit hacky but what if you did something in the index.js that used resolve to check what version ember-fetch is actually installed and throw an error if it's too low?

[NullVoxPopuli]

do peerDependencies not solve this?

[mansona]

@NullVoxPopuli I think it's just a warning when it comes to peerDependencies 🤔 but I could be wrong

[xg-wang]

peerDependency just writes a warning. Forcing it to an error can be done by ember-cli-version-checker

[runspired]

@xg-wang is correct, and likely that’s what we should do.

[runspired]

I’m a bit hesitant to do something that forces folks to install ember-fetch as much as I want to eliminate jQuery. We should likely make whether it is required “optional” and only use version checker to enforce if the flag is not set to drop it.

[tchak]

Si it should throw an error only if no jQuery support is enabled and ember-fetch is absent or lower than required version, correct?

[runspired]

@tchak I was thinking more broad: as in it should likely be the default that without jquery we expect fetch, but folks should be able to opt out of both.

[xg-wang]

shouldIncludeChildAddon(childAddon) {
      if (childAddon.name === 'ember-fetch') {
        return !HAS_JQUERY;
      } else {
        return this._super.shouldIncludeChildAddon.apply(this, arguments);
      }
    }

I think this could do it. To check top level & sibling ember-fetch existence should be done in ember-fetch self's cli hook.

[dcyriller]

I’m a bit hesitant to do something that forces folks to install ember-fetch as much as I want to eliminate jQuery
folks should be able to opt out of both

@runspired how do you see the opt out strategy? I guess the fallback would be on a non-polyfilled version of fetch (what about fastboot?). In config/environment.js, we could toggle the native fetch strategy this way?

module.exports = function(environment) {
  var ENV = {
    'ember-data': {
      useNativeFetch: true // defaults to false
    }
  }
}

@tchak I've done a PR (targeting yours) to throw an error in case of dependency mismatch.

[simonihmig]

The quest to remove jQuery by default as per RFC386 is making good progress. Part of it is also resolving this issue.

So is there a chance we can land this in the near future? Ideally in a forthcoming 3.9 release? (which is the version of Ember which will add the additional jQuery deprecations)

[NullVoxPopuli]

where can we view the status of this?

[runspired]

@runspired how do you see the opt out strategy? I guess the fallback would be on a non-polyfilled version of fetch (what about fastboot?). In config/environment.js, we could toggle the native fetch strategy this way?

@dcyriller I think i'm going to skip on this requirement for now and add it as a feature later if folks need. Is all that is needed to land a rebase at this point?

[runspired]

Closing in favor of #5900