Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC #0386 - Tracking for Remove jQuery by Default #3

Open
kategengler opened this issue Feb 12, 2019 · 6 comments

Comments

@kategengler
Copy link
Member

commented Feb 12, 2019

RFC #0386 - Remove jQuery by Default

Champion: @rwjblue


Expand for Instructions

All teams need to consider a merged RFC to plan any required work. Each team should comment on or edit this with links to issues for the work (or a note to the effect of "No work required").

See the README for more information
See #3 for an example

Under each team, for each repo requiring work for the RFC under that team:
### [repo name](repo url)

- [ ] (issue or pr) description, (issue or pr) link

Remove Repos that do not apply, conversely, there will probably be other repos that need work and should be added.

[Filled out from @simonihmig's Quest issue]

Ember.js Team:

ember.js

Removal phase (4.0)

  • remove deprecated functions
  • remove the jQuery specific code paths in the EventDispatcher

@ember/jquery

@ember/test-helpers

Ember CLI Team:

ember-cli

ember-cli-babel

Ember Data Team:

ember-data

ember-fetch

  • Provide a replacement API for jQuery's prefilter

Learning Team:

Website

guides-source

  • remove usages of import $, this.$(), and $.ajax

ember.js

  • review API documentation for usage of jQuery

ember-data

  • review API documentation for usage of jQuery

Steering Committee:

No work expected

@simonihmig simonihmig referenced this issue Feb 12, 2019

Closed

[QUEST] Remove jQuery #17476

9 of 16 tasks complete

@kategengler kategengler added this to Accepted in RFC Tracking Mar 1, 2019

@kategengler kategengler moved this from Accepted to Planning in RFC Tracking Mar 1, 2019

@simonihmig

This comment has been minimized.

Copy link

commented Mar 10, 2019

The ember-data todo can be checked off, as per emberjs/data#5900! 🎉

@MelSumner MelSumner referenced this issue Apr 2, 2019

Open

Octane Tracking Issue #17234

81 of 140 tasks complete

@runspired runspired referenced this issue Apr 4, 2019

Open

RFC #0403- Tracking for [DATA] identifiers #31

0 of 6 tasks complete
@rwjblue

This comment has been minimized.

Copy link
Member

commented May 2, 2019

We reworked the fetch support in ember-data over in emberjs/data#6077.

emberjs/data#5975 is working to ensure ember-data's CI is running properly without jQuery.

@nlfurniss

This comment has been minimized.

Copy link

commented Jun 19, 2019

@simonihmig for remove usages of import $, this.$(), and $.ajax, this there a starting version of the docs we're targeting?

It doesn't make sense to remove jQuery mentions in v1.0.0 of the docs, but maybe starting from 3.0.0 it does?

@simonihmig

This comment has been minimized.

Copy link

commented Jun 21, 2019

It doesn't make sense to remove jQuery mentions in v1.0.0 of the docs, but maybe starting from 3.0.0 it does?

AFAIK docs for past versions will not be updated in general, only for the latest release, right?

Not sure what's still left to do here? I found these references of jQuery usage, but they all seem to have been fixed already.

@nlfurniss

This comment has been minimized.

Copy link

commented Jun 21, 2019

It doesn't make sense to remove jQuery mentions in v1.0.0 of the docs, but maybe starting from 3.0.0 it does?

AFAIK docs for past versions will not be updated in general, only for the latest release, right?

Not sure what's still left to do here? I found these references of jQuery usage, but they all seem to have been fixed already.

In that case I think the docs item can be checked off :-)

@rwjblue

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Just merged the ember-cli update to drop jQuery for ember new foo (generally slated for ember-cli@3.13 at this point).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.