Tether tooltips #1089
Closed
Tether tooltips #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-inspector into capture-render-tree
wycats
force-pushed
the
capture-render-tree
branch
2 times, most recently
from
f865a0b
to
c4d7675
Compare
chancancode
added a commit
that referenced
this pull request
Dec 19, 2019
* Add a polyfill for the `captureRenderTree` API * GlimmerTree -> RenderTree * [WIP] view inspecting * Correctly insert outlet nodes * Wire-up more of the UI * Get pinning working * Fix vertical-collection * Fix object inspection * Fix polyfill * Tooltip positionining Closes #1089 * Use polyfill for 3.14.0/3.14.1 * Set `EmberENV._DEBUG_RENDER_TREE` * Some improvements to the tooltip * Refactor render tree to use Octane idioms * Fix debouncing, don't cause a ton of user-runloops * Don't shadow methods (requested by @rwjblue) * Implement remaining features * Automatically scroll to the appropiate row * Make sure the view inspection tooltips and the inspector tab stays in sync * Fix pinning * Some performance improvements * General cleanup, ensure correct teardown * Revert to updating component tree with instrumentation While the backburner-based approach is technically more correct, it turns out that ember in practice always fire the instrumentation events due to the route templates (including the internal -top-level) being instrumented by default. This gives more favorable results since we start way too many runloops when we shouldn't have to. * Don't show empty rects * Fix app-picker tests * remove unused code * Fix component tests * Fix view debug tests * Fix style lint * PR comments * Fix 3.4 outlet template location * Fix @model arg on 3.14 * Skip debounce when requesting the first render tree * unify view debug and component tree tests * Refactor render-tree * Refactor view-inspection
nummi
pushed a commit
to nummi/ember-inspector
that referenced
this pull request
Apr 1, 2020
…s#1088) * Add a polyfill for the `captureRenderTree` API * GlimmerTree -> RenderTree * [WIP] view inspecting * Correctly insert outlet nodes * Wire-up more of the UI * Get pinning working * Fix vertical-collection * Fix object inspection * Fix polyfill * Tooltip positionining Closes emberjs#1089 * Use polyfill for 3.14.0/3.14.1 * Set `EmberENV._DEBUG_RENDER_TREE` * Some improvements to the tooltip * Refactor render tree to use Octane idioms * Fix debouncing, don't cause a ton of user-runloops * Don't shadow methods (requested by @rwjblue) * Implement remaining features * Automatically scroll to the appropiate row * Make sure the view inspection tooltips and the inspector tab stays in sync * Fix pinning * Some performance improvements * General cleanup, ensure correct teardown * Revert to updating component tree with instrumentation While the backburner-based approach is technically more correct, it turns out that ember in practice always fire the instrumentation events due to the route templates (including the internal -top-level) being instrumented by default. This gives more favorable results since we start way too many runloops when we shouldn't have to. * Don't show empty rects * Fix app-picker tests * remove unused code * Fix component tests * Fix view debug tests * Fix style lint * PR comments * Fix 3.4 outlet template location * Fix @model arg on 3.14 * Skip debounce when requesting the first render tree * unify view debug and component tree tests * Refactor render-tree * Refactor view-inspection
nummi
pushed a commit
to nummi/ember-inspector
that referenced
this pull request
Apr 5, 2020
…s#1088) * Add a polyfill for the `captureRenderTree` API * GlimmerTree -> RenderTree * [WIP] view inspecting * Correctly insert outlet nodes * Wire-up more of the UI * Get pinning working * Fix vertical-collection * Fix object inspection * Fix polyfill * Tooltip positionining Closes emberjs#1089 * Use polyfill for 3.14.0/3.14.1 * Set `EmberENV._DEBUG_RENDER_TREE` * Some improvements to the tooltip * Refactor render tree to use Octane idioms * Fix debouncing, don't cause a ton of user-runloops * Don't shadow methods (requested by @rwjblue) * Implement remaining features * Automatically scroll to the appropiate row * Make sure the view inspection tooltips and the inspector tab stays in sync * Fix pinning * Some performance improvements * General cleanup, ensure correct teardown * Revert to updating component tree with instrumentation While the backburner-based approach is technically more correct, it turns out that ember in practice always fire the instrumentation events due to the route templates (including the internal -top-level) being instrumented by default. This gives more favorable results since we start way too many runloops when we shouldn't have to. * Don't show empty rects * Fix app-picker tests * remove unused code * Fix component tests * Fix view debug tests * Fix style lint * PR comments * Fix 3.4 outlet template location * Fix @model arg on 3.14 * Skip debounce when requesting the first render tree * unify view debug and component tree tests * Refactor render-tree * Refactor view-inspection
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
…s#1088) * Add a polyfill for the `captureRenderTree` API * GlimmerTree -> RenderTree * [WIP] view inspecting * Correctly insert outlet nodes * Wire-up more of the UI * Get pinning working * Fix vertical-collection * Fix object inspection * Fix polyfill * Tooltip positionining Closes emberjs#1089 * Use polyfill for 3.14.0/3.14.1 * Set `EmberENV._DEBUG_RENDER_TREE` * Some improvements to the tooltip * Refactor render tree to use Octane idioms * Fix debouncing, don't cause a ton of user-runloops * Don't shadow methods (requested by @rwjblue) * Implement remaining features * Automatically scroll to the appropiate row * Make sure the view inspection tooltips and the inspector tab stays in sync * Fix pinning * Some performance improvements * General cleanup, ensure correct teardown * Revert to updating component tree with instrumentation While the backburner-based approach is technically more correct, it turns out that ember in practice always fire the instrumentation events due to the route templates (including the internal -top-level) being instrumented by default. This gives more favorable results since we start way too many runloops when we shouldn't have to. * Don't show empty rects * Fix app-picker tests * remove unused code * Fix component tests * Fix view debug tests * Fix style lint * PR comments * Fix 3.4 outlet template location * Fix @model arg on 3.14 * Skip debounce when requesting the first render tree * unify view debug and component tree tests * Refactor render-tree * Refactor view-inspection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.