This repository has been archived by the owner on May 26, 2019. It is now read-only.
Add Ember Inspector guides #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bsclifton this is related to your pr right? |
|
This is really similar! It has images, which make it easier to understand. I can definitely merge this into my PR here: |
| inspect these instances using the inspector's container tab. | ||
|
|
||
|
|
||
| <img src="/images/guides/ember-inspector/container-screenshot.png" width="680"/> |
There was a problem hiding this comment.
images can't be absolute, since the output of a build lives inside a subdirectory.
|
Looks good but we'd need to make all the absolute urls relative instead. |
teddyzeenny
force-pushed
the
ember-inspector
branch
from
5e21d13
to
b22ddcf
Compare
|
Updated to use relative image urls. Thanks @trek for reviewing. |
|
Wow- lots of updates since I've seen this last, great job 😄 When I made the comment above, I had only seen a single page which had Ember Inspector details, which was similar to what I had (but better, w/ images). I'm going to remove the content from my PR |
|
@teddyzeenny awesome job! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots at emberjs/website#2030