This repository has been archived by the owner on May 26, 2019. It is now read-only.
Merged Guides content from https://github.com/emberjs/website/pull/1956 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
…ork, has changes pending PR here: LeonB/middleman-swiftype#4).
…can be removed, wanted to share in slack.
|
Can you extract just the swiftype parts? |
Conflicts: Gemfile.lock config.rb
|
Keeping open- sorry to n00b it up, I'm still working on my Git skills :) |
Conflicts: Gemfile.lock README.md
Removed globals from `object-model`
Updated `controllers` to use Ember CLI
ember-cli rewrite of the Models section
Remove deprecations page, which is part of main website
|
@bsclifton I've removed the "Getting started" section in #65. We can relocate later, IMO. |
Moves 'concepts' section to cli style
Update: Ember cookbook to cli
Inform the user that all code blocks must be fenced with proper language designation.
* Refactor few TOC methods after adding tests. * Introduce spec_helper
* Run the specs & trigger middleman build to catch build errors.
…uage-where-necessary Add fenced code block with language wherever necessary.
Handle nil language in highlighter
Update routes sections for Ember CLI
[WIP] Updates getting ember section for ember-cli style
|
Can you squash this |
CLI-style for 'understanding-ember' section
updating customizing updated a jsbin finished adding JSbins changing spaces to 2 instead of 4, reducing var CreateWhatever more spacing and export changes indent inside if statement with 2 spaces JSBin changes and small space fixes new formatting for file path new formatting for file path updating file path formatting commented out JSbins Fixed Typo Just fixing a small typo: "for build a basic controls live text inputs, ..." to "for build basic controls live text inputs, ..." removed JSbins and added formatting to another file Moved rails-assets-* to their own block. Update list of injectable things Convert views (as best we can) to ember-cli fixes as per rwblue comments fixes as per rwblue comments removing imports and newlines removed double 'a', indentation and incorrect file extension removed indents Add deprecations for non-block-param helpers For emberjs/ember.js#10583 and emberjs/ember.js#10584 Updates record lifecycle section for ember-cli Update contributions section for CLI Remove global from feature flag Removed globals from object-model Updated `controllers` to use Ember CLI Don't import Ember Updates "Models" section for ember-cli Remove deprecations page, which is part of main website Moves 'concepts' section to cli style Update "Cookbook" for ember-cli Add fenced code block with language wherever necessary. Raise MissingLanguageError if no language is specified by Highlighter. Inform the user that all code blocks must be fenced with proper language designation. Add unit tests to TOC. * Refactor few TOC methods after adding tests. * Introduce spec_helper Introducing Travis CI * Run the specs & trigger middleman build to catch build errors. Update routing documentation for Ember CLI Remove global controllers from code samples Adjust code blocks & conventions for async routing Use filenames in route defining tables Omit custom generated controllers I’d like to rework this part but right now it doesn’t fit into the rest. Remove globals from index Adjust code block notation; swap naming convention in router flow Adjust code blocks; change routes Not sure about the syntax for the legacy `LoadingRoute` section. Adjust code blocks, naming conventions Adjust code blocks; naming conventions for query params Adjust code blocks for sending events Fix code blocks in template rendering Adjust code blocks and naming conventions Adjust code blocks and naming conventions for specifying model Fix erroneous character Replaces "Getting Ember" for PR #7 CLI-style for 'understanding-ember' section
|
I messed something up along the way :/ Need to work on my git-fu. Closing and will re-open a PR with only the changes needed (edit: opened #75) |
pixelhandler
pushed a commit
to pixelhandler/emberwatch
that referenced
this pull request
Sep 4, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.