This repository was archived by the owner on May 26, 2019. It is now read-only.
QUEST | Convert code samples to RFC #176 imports #2004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks
force-pushed
the
new-imports
branch
4 times, most recently
from
33832b7 to
5cb7340
Compare
This was referenced Aug 3, 2017
This was referenced Aug 11, 2017
Closed
locks
force-pushed
the
new-imports
branch
2 times, most recently
from
512e866 to
ee4010a
Compare
|
Marking testing as completed, thanks for your help @aureliosaraiva ! |
juwara0
reviewed
Sep 19, 2017
| baz: {foo: 'BLAMMO', bar: 'BLAZORZ'}, | ||
|
|
||
| something: Ember.computed('baz.foo', 'baz.bar', function() { | ||
| something: Embercomputed('baz.foo', 'baz.bar', function() { |
There was a problem hiding this comment.
One of the Embercomputed conversions ^ got missed.
* Tutorial/Simple-component * Converts Tutorials * Update hbs-helper.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC #176 introduces new modular imports so that you can import only the parts of Ember that you require inside that file.
We need your help converting all of the code samples in the Guides to the new style of imports!
Contributing
2.1. Update
importstatements in code sample to the new imports.2.2. Update links to API docs. For example, change the link text from
Ember.ComponenttoComponent.new-importsbranch, which is this one.FAQ
I can't find the class/method in the correspondence table
Check if the API is private or public.
If it is private, the Guide should be changed to not use it.
You can post here for help, or in your own PR.
If it is public, there might have been a lapse.
Comment in ember-cli/ember-rfc176-data#12 and we'll help you sort it out!
Should I rebase? Why do I have to target the
new-importsbranch?We will take care of rebasing and otherwise updating this branch as works continues.
We need to do this until 2.16 is released because we have Continuous Integration on the master branch, so any PRs merged get deployed as soon as CI finishes building.
Guides section list