Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

ember-cli rewrite of the Models section #8

Merged
merged 1 commit into from
Mar 20, 2015
Merged

ember-cli rewrite of the Models section #8

merged 1 commit into from
Mar 20, 2015

Conversation

locks
Copy link
Contributor

@locks locks commented Feb 22, 2015

Ready to merge.

@trek
Copy link
Member

trek commented Mar 17, 2015

Is this mergeable yet or no?

@locks
Copy link
Contributor Author

locks commented Mar 17, 2015

Not yet, I have questions regarding a section and then a final review.
On 17 Mar 2015 16:32, "Trek Glowacki" notifications@github.com wrote:

Is this mergeable yet or no?


Reply to this email directly or view it on GitHub
#8 (comment).

@rwjblue
Copy link
Member

rwjblue commented Mar 18, 2015

Please let us know what you are blocked on, so we can help move it forward.

@locks locks changed the title [WIP] ember-cli rewrite of the Models section ember-cli rewrite of the Models section Mar 19, 2015
@locks
Copy link
Contributor Author

locks commented Mar 19, 2015

@trek mergeable

@stevekinney
Copy link
Contributor

I reviewed this and it looks good. :shipit:

@trek
Copy link
Member

trek commented Mar 20, 2015

Can you squash this down for us? Thanks.

@locks
Copy link
Contributor Author

locks commented Mar 20, 2015

@trek :shipit:

trek added a commit that referenced this pull request Mar 20, 2015
ember-cli rewrite of the Models section
@trek trek merged commit ec7b2f2 into emberjs:master Mar 20, 2015
@locks locks deleted the ember-cli/data branch March 20, 2015 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants