Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

Background info #85

Closed
wants to merge 3 commits into from
Closed

Background info #85

wants to merge 3 commits into from

Conversation

michaelrkn
Copy link
Contributor

Addresses #79.



## Virtual DOM
**Not to be confused with Shadow DOM**. Ember's [Glimmer enginer](https://github.com/emberjs/ember.js/pull/10501) will implement a Virtual DOM to dramatically improve rendering performance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/enginer/engine :)

@joostdevries
Copy link
Contributor

I like the fact that you're trying to separate the "must understands" from the "would be good to understand/you should already understand" but I'd name it as such. If you don't get what's listed in background, you're going to have a bad time.

Another thing: we should have a clear idea on the different problems we want to solve:

  1. Have people understand the foundation before getting started
  2. Teach people the right conventions
  3. Help people troubleshoot issues arising from not doing 1&2.

Right now, this seems to focus on 1. I've already commented in other issues that for example teaching people to import is highly critical or they will end up with dozens of JSHint errors.

@joostdevries
Copy link
Contributor

Just read through the rest of the pages and I agree with @trek that it would make sense to move this to its own section. There's actually a dedicated Concepts section in the Guide which now has Core concepts and Naming conventions. The Background info and Glossary sections would make most sense there I guess.

@michaelrkn
Copy link
Contributor Author

Thanks for the feedback. I've updated the PR. Let me know what you all think now.

@joostdevries
Copy link
Contributor

@michaelrkn put my suggestions in #89 . (did not see your comment)

@michaelrkn
Copy link
Contributor Author

Is there a reason this hasn't been merged? I just had to go back and rebase to fix merge conflicts with other changes since I opened this.

/cc @trek @rwjblue

@michaelrkn
Copy link
Contributor Author

Closing this in favor of a simpler PR with fewer changes to make it easier to review

@michaelrkn michaelrkn closed this Apr 5, 2015
@michaelrkn michaelrkn deleted the background-info branch April 5, 2015 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants