How do I enable private methods?

[NullVoxPopuli]

I'm surprised they aren't enabled by default? because ember-cli-babel has them 🙃

but anywho, I have this error in C.I.: https://github.com/NullVoxPopuli/ember-array-map-resource/pull/103/checks?check_run_id=3702630696#step:5:215

 - originalErrorMessage: /home/runner/work/ember-array-map-resource/ember-array-map-resource/-private/resources/array-map.ts: Class private methods are not enabled.
  20 |
  21 |   // @private
> 22 |   get #records(): Element[] {
     |   ^
  23 |     return this.args.positional[0];
  24 |   }
  25 |
  - stack: SyntaxError: /home/runner/work/ember-array-map-resource/ember-array-map-resource/-private/resources/array-map.ts: Class private methods are not enabled.

Classic build works just fine with private fields: https://github.com/NullVoxPopuli/ember-array-map-resource/pull/103/checks?check_run_id=3702630588

[ef4]

I can't reproduce this. I tested private fields working in both an app and an addon. Maybe you have old dependencies (like a @babel/preset-env) in a lockfile?

[NullVoxPopuli]

I re-rolled the lockfile and got the same issue: https://github.com/NullVoxPopuli/ember-array-map-resource/pull/106/checks?check_run_id=3714144862#step:5:215

I think the issue is more private methods rather than private fields -- I'm surprised these are different implementation-wise in Babel.

But yeah, private fields already work just fine.

What's goofy is that private methods are natively supported,

though, my targets currently include safari: https://github.com/NullVoxPopuli/ember-array-map-resource/blob/main/config/targets.js#L3

I wonder if that's why transpilation is even occurring.

I've added a private getter here: https://github.com/embroider-build/embroider/pull/982/files to see if the test suite passes with this addition

[NullVoxPopuli]

ember-cli-babel has private methods here: https://github.com/babel/ember-cli-babel/blob/085c408b88a058bdbcaa298a5e59c9511e832073/lib/babel-options-util.js#L403
but only in the else condition. 🤔

I searched embroider for @babel/plugin-proposal-private-methods but it couldn't be found. 🤔
I shall add it!

[courajs]

Been running into this as well. Discovered @embroider/webpack depends on the old pre-release version of babel's preset env. babel-preset-env has been deprecated in favor of @babel/preset-env.
Looks like the new versions use plugin-proposal-private-methods: https://github.com/babel/babel/blob/87fc2e76d77b0bc78b76cced469bd64c5edf141f/packages/babel-preset-env/package.json#L37
But the pre-release package doesn't: https://github.com/babel/babel-preset-env/blob/31f33e3656e1bd8036317c54128fdc2812a2e8aa/package.json#L24

So I believe the solution is to migrate from babel-preset-env to @babel/preset-env

[rwjblue]

@courajs - I don't think we are using that dep at all actually...

[rwjblue]

I believe this is the same thing I described in emberjs/ember-cli-babel#419 (comment), since we use ember-cli-babel for compilation still we're going to have the same issue.

[ef4]

I suspect this is fixed by emberjs/ember-cli-babel#420

[NullVoxPopuli]

I'll double check real quick

[NullVoxPopuli]

I ran in to a separate issue,
About cache missing: https://github.com/NullVoxPopuli/ember-array-map-resource/runs/4588181014?check_suite_focus=true#step:5:93
#1020

[NullVoxPopuli]

ok, too much going on here, there is the minimal test:
NullVoxPopuli/ember-array-map-resource#212

and it succeeded! yay!
confirm fixed.