Temporarily disable wasm EH build #13439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation for the new EH spec started landing in LLVM and Binaryen recently, but it has not been well tested against building Emscripten libraries yet. This disables wasm EH build temporarily; we will re-enable it once the implementation is stabilized.
sbc100
approved these changes
Feb 7, 2021
aheejin
added a commit
to aheejin/emscripten
that referenced
this pull request
Feb 23, 2021
This reverts emscripten-core#13439, given that now libraries can be built with wasm EH enabled.
aheejin
added a commit
to aheejin/emscripten
that referenced
this pull request
Feb 26, 2021
This reverts emscripten-core#13439, given that now libraries can be built with wasm EH enabled.
aheejin
added a commit
that referenced
this pull request
Feb 27, 2021
This reverts #13439, given that now libraries can be built with wasm EH enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation for the new EH spec started landing in LLVM and
Binaryen recently, but it has not been well tested against building
Emscripten libraries yet. This disables wasm EH build temporarily; we
will re-enable it once the implementation is stabilized.