Report more undefined symbols at wasm-ld time #21000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Jan 4, 2024
tools/building.py
Outdated
| for export in settings.REQUIRED_EXPORTS: | ||
| if settings.ERROR_ON_UNDEFINED_SYMBOLS: | ||
| # We give special treatment to the `main` function since its | ||
| # always allowed to be undefined. |
There was a problem hiding this comment.
Is main always allowed to be undefined, even if it is in EXPORTED_FUNCTIONS?
There was a problem hiding this comment.
I was being lazy here... refactored to avoid this special case.
sbc100
force-pushed
the
wasm_ld_report_undefined
branch
from
aa88b69 to
96163a3
Compare
sbc100
force-pushed
the
wasm_ld_report_undefined
branch
from
96163a3 to
958042d
Compare
kripken
approved these changes
Jan 4, 2024
sbc100
force-pushed
the
wasm_ld_report_undefined
branch
from
958042d to
35e3336
Compare
Symbols that are part of EXPORTED_FUNCTIONS are now reported by wasm-ld.
sbc100
force-pushed
the
wasm_ld_report_undefined
branch
from
35e3336 to
50a76e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbols that are part of EXPORTED_FUNCTIONS are now reported by wasm-ld.