Skip to content

Use JS optional chaining in more places. NFC #22087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2024
Merged

Use JS optional chaining in more places. NFC #22087

merged 1 commit into from
Jun 11, 2024

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jun 11, 2024

.

@sbc100 sbc100 requested review from kripken and RReverser June 11, 2024 17:12
@sbc100 sbc100 force-pushed the optional_chaining branch from 2a25676 to b9b8ced Compare June 11, 2024 17:15
kripken
kripken approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like ??= was added in exactly the Chrome/Firefox/Safari minimum versions we support by default, convenient...

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing_assignment

(and ?. was even earlier apparently)

Interesting it hurts gzip size in some cases but that seems like just noise.

@RReverser
Copy link
Collaborator

RReverser commented Jun 11, 2024 •
edited
Loading

Looks like ??= was added in exactly the Chrome/Firefox/Safari minimum versions we support by default, convenient...

It's because we bumped versions we support specifically to support that operator during the first mass-refactor PR 😅

@kripken
Copy link
Member

kripken commented Jun 11, 2024

Oh cool 😆 no coincidence then...

@sbc100 sbc100 merged commit dd0c250 into emscripten-core:main Jun 11, 2024
@sbc100 sbc100 deleted the optional_chaining branch June 11, 2024 20:12
@dschuff dschuff mentioned this pull request Oct 29, 2024
Merged
@dschuff dschuff mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

@RReverser RReverser RReverser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbc100 @RReverser @kripken