Skip to content

Fix minimap selection extend limits in toolchain profiler view. #25057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2025
Merged

Fix minimap selection extend limits in toolchain profiler view. #25057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions tools/toolchain_profiler.results_template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,11 +588,12 @@
.attr('d', function(d) { return d.path; });

// draw the selection area
var selectionExtent = [
d3.min(items, function(d) { return d.start; }),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(d) => d.start

d3.max(items, function(d) { return d.end; })];
var brush = d3.svg.brush()
.x(x)
.extent([
d3.min(items, function(d) { return d.start; }),
d3.max(items, function(d) { return d.end; })])
.extent(selectionExtent)
.on("brush", display);

mini.append('g')
Expand All @@ -606,8 +607,8 @@
display();

function display () {
var minExtent = Math.max(0, brush.extent()[0]);
var maxExtent = Math.min(lastEndTime, brush.extent()[1]);
var minExtent = Math.max(selectionExtent[0], brush.extent()[0]);
var maxExtent = Math.min(selectionExtent[1], brush.extent()[1]);
var visItems = items.filter(function (d) { return d.start < maxExtent && d.end > minExtent});

mini.select('.brush').call(brush.extent([minExtent, maxExtent]));
Expand Down