Skip to content

Do not halve the number of used cores in testing #25201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2025
Merged

Do not halve the number of used cores in testing #25201

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d95b3ac
Do not halve the number of used cores if the user has explicitly spec…
juj Sep 5, 2025
e4c2ad9
Check EMCC_CORES as well
juj Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/parallel_testsuite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ def python_multiprocessing_structures_are_buggy():


def cap_max_workers_in_pool(max_workers, is_browser):
if is_browser:
if is_browser and 'EMTEST_CORES' not in os.environ and 'EMCC_CORES' not in os.environ:
# TODO experiment with this number. In browser tests we'll be creating
# a chrome instance per worker which is expensive.
max_workers = int(max_workers / 2)
max_workers = max_workers // 2
# Python has an issue that it can only use max 61 cores on Windows: https://github.com/python/cpython/issues/89240
if WINDOWS:
return min(max_workers, 61)
Expand Down