Use shared/common symbol export mechanism for tag (i.e. __cpp_exception). NFC #25286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschuff
reviewed
Sep 16, 2025
|
|
||
| receiving.append('\nfunction assignWasmExports(wasmExports) {') | ||
| for sym, sig in exports.items(): | ||
| is_function = sig is not None |
There was a problem hiding this comment.
I'm not totally sure how Emscripten is currently handling tags, but at least in wasm, tags have signatures too (the return value is void and the arguments are the payload type). In C++ we only use i32-payload tags, and maybe that's fine for Emscripten, but if we want this linking method to be fully general it should handle other tag types.
There was a problem hiding this comment.
This exports map only stores signatures for functions (since we don't care about tag signatures here)
There was a problem hiding this comment.
(See the = None assignment above)
dschuff
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.