Skip to content

Improve benchmark.test_zzz_poppler to partially build in MEMORY64 mode #25338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2025
Merged

Improve benchmark.test_zzz_poppler to partially build in MEMORY64 mode #25338

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
232faca
Improve benchmark.test_zzz_poppler to partially build in MEMORY64 mod…
juj Sep 20, 2025
b7e3c6d
ruff
juj Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions test/test_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ def do_benchmark(self, name, src, expected_output='FAIL', args=None,
emcc_args=None, native_args=None, shared_args=None,
force_c=False, reps=TEST_REPS, native_exec=None,
output_parser=None, args_processor=None, lib_builder=None,
skip_native=False):
skip_benchmarkers=None):
if not benchmarkers:
raise Exception('error, no benchmarkers')

Expand All @@ -452,7 +452,7 @@ def do_benchmark(self, name, src, expected_output='FAIL', args=None,
print()
baseline = None
for b in benchmarkers:
if skip_native and isinstance(b, NativeBenchmarker):
if skip_benchmarkers and b.name in skip_benchmarkers:
continue
if not b.run:
# If we won't run the benchmark, we don't need repetitions.
Expand Down Expand Up @@ -1113,14 +1113,19 @@ def test_zzz_poppler(self):
''' % DEFAULT_ARG)

def lib_builder(name, native, env_init): # noqa
if '-sMEMORY64' in env_init['CFLAGS']:
env_init['CPPFLAGS'] = '-sMEMORY64'
env_init['LDFLAGS'] = '-sMEMORY64'
return self.get_poppler_library(env_init=env_init)

# TODO: Fix poppler native build and remove skip_native=True
self.do_benchmark('poppler', '', 'hashed printout',
shared_args=['-I' + test_file('poppler/include'),
'-I' + test_file('freetype/include')],
emcc_args=['-sFILESYSTEM', '--pre-js=pre.js', '--embed-file',
test_file('poppler/emscripten_html5.pdf') + '@input.pdf',
'-sERROR_ON_UNDEFINED_SYMBOLS=0',
'-sMINIMAL_RUNTIME=0'], # not minimal because of files
lib_builder=lib_builder, skip_native=True)
lib_builder=lib_builder,
# TODO: Fix poppler native and freetype MEMORY64 builds to be able
# to remove these skips
skip_benchmarkers=['clang', 'gcc', 'v8-64', 'node-64'])