Skip to content

Improve firefox window cascading #25339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2025
Merged

Improve firefox window cascading #25339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6846f55
Improve browser window cascading on Windows to also work in the case …
juj Sep 21, 2025
c1dc580
appease mypy
juj Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,5 +106,5 @@ module = [
ignore_errors = true

[[tool.mypy.overrides]]
module = ["psutil", "win32gui", "win32process"]
module = ["psutil", "win32con", "win32gui", "win32process"]
ignore_missing_imports = true
11 changes: 9 additions & 2 deletions test/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2603,14 +2603,21 @@ def __exit__(self, *a):
def move_browser_window(pid, x, y):
"""Utility function to move the top-level window owned by given process to
(x,y) coordinate. Used to ensure each browser window has some visible area."""
import win32con
import win32gui
import win32process

def enum_windows_callback(hwnd, _unused):
_, win_pid = win32process.GetWindowThreadProcessId(hwnd)
if win_pid == pid and win32gui.IsWindowVisible(hwnd):
rect = win32gui.GetWindowRect(hwnd)
win32gui.MoveWindow(hwnd, x, y, rect[2] - rect[0], rect[3] - rect[1], True)
# If the browser window is maximized, it won't react to MoveWindow, so
# un-maximize the window first to show it in windowed mode.
if win32gui.GetWindowPlacement(hwnd)[1] == win32con.SW_SHOWMAXIMIZED:
win32gui.ShowWindow(hwnd, win32con.SW_RESTORE)

# Then cascade the window, but also resize the window size to cover a
# smaller area of the desktop, in case the original size was full screen.
win32gui.MoveWindow(hwnd, x, y, 800, 600, True)
return True

win32gui.EnumWindows(enum_windows_callback, None)
Expand Down
Loading