Fix naming of temp object files in emcc. NFC #25389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschuff
approved these changes
Sep 25, 2025
sbc100
force-pushed
the
tmp_object_file_naming
branch
from
3f57fca to
a48f13c
Compare
The existing code was naming every object file with an `_N` suffix where N was the number files seen so far. This meant we were using suffixes for all files, not just files that were duplicates.
sbc100
force-pushed
the
tmp_object_file_naming
branch
from
a48f13c to
6b626da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code was naming every object file with an
_Nsuffix where N was the number files seen so far. This meant we were using suffixes for all files, not just files that were duplicates.