-sEXPORT_ES6 and multithreading too old browsers. #25408
Merged
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith too old target browser versions.
sbc100
approved these changes
Sep 29, 2025
|
Naively adding So changed this PR to establish ES6 Module Workers as a feature instead. |
sbc100
approved these changes
Sep 29, 2025
| #endif | ||
| #if MIN_SAFARI_VERSION < 150000 | ||
| #error new Worker() supports ECMAScript module only starting from Safari 15. Pass -sMIN_SAFARI_VERSION=150000 to target -sEXPORT_ES6 with -pthread. See https://caniuse.com/mdn-api_worker_worker_ecmascript_modules | ||
| #endif |
There was a problem hiding this comment.
It is even possible to hit these error now that the feature is added? i.e. -sEXPORT_ES6 + -pthreads will now force the correct versions or fail, right?
There was a problem hiding this comment.
I was pondering the same, so wanted to add these in to verify that won't be the case. Doesn't hurt to have them?
Or I could remove them - but seems like they're safe to have, they could trigger on possible refactors down the road.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 29, 2025
Without this change it might appear that this is where the check/enforcement is happening, but its actually done by the feature_matrix.
sbc100
added a commit
that referenced
this pull request
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abort build if attempting to target -sEXPORT_ES6 and multithreading with too old target browser versions.Add ES6 Module Workers as feature in the feature matrix.