Skip to content

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 29, 2025

This helps with debugging since the runtime-generated functions show up in backtraces with meaningful names.

@sbc100 sbc100 requested review from dschuff and kripken September 29, 2025 04:54
@sbc100 sbc100 force-pushed the createNamedFunction branch from ebcb6a0 to 2799049 Compare September 29, 2025 05:10
setTempRet0: '$setTempRet0',
getTempRet0: '$getTempRet0',

// Assign a name of given function. This is mostly useful for debugging
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Assign a name of given function. This is mostly useful for debugging
// Assign a name to a given function. This is mostly useful for debugging

This helps with debugging since the runtime-generated functions show
up in backtraces with meaningful names.
@sbc100 sbc100 force-pushed the createNamedFunction branch from 2799049 to ec2dce7 Compare September 29, 2025 15:52
@sbc100 sbc100 merged commit 508bcb0 into emscripten-core:main Sep 29, 2025
3 of 14 checks passed
@sbc100 sbc100 deleted the createNamedFunction branch September 29, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants