Skip to content

Conversation

juj
Copy link
Collaborator

@juj juj commented Sep 29, 2025

Add item for OffscreenCanvas support in feature matrix, and update missing @requires_offscreen_canvas in browser test.

This will automatically set min browser versions when -sOFFSCREEN_CANVAS is used, and error our if the users explicitly requests a too-old browser version

…ssing @requires_offscreen_canvas in browser test.
self.btest_exit('webgl_create_context2.c')

@requires_graphics_hardware
@requires_offscreen_canvas
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't only one of the variants require it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's right.

I thought to keep this change simple and over-conservative, to avoid too much churn from testing old browsers.

@sbc100
Copy link
Collaborator

sbc100 commented Sep 29, 2025

Can you mention in the PR description what the effect this is, since I don't think its obvious.

Correct me if I'm wrong but something like: "This will automatically set min browser versions when -sOFFSCREEN_CANVAS is used, and error our if the users explictly requests a too-old browser version".

@juj
Copy link
Collaborator Author

juj commented Sep 29, 2025

Correct me if I'm wrong but something like: "This will automatically set min browser versions when -sOFFSCREEN_CANVAS is used, and error our if the users explictly requests a too-old browser version".

That's good. Added, thanks.

@juj juj merged commit 78275e2 into emscripten-core:main Sep 29, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants