Skip to content

Add warning about usage of embind without C++17 #25424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

Add warning about usage of embind without C++17 #25424

merged 1 commit into from
Sep 30, 2025
+15 −10

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 29, 2025

See #24850

@sbc100 sbc100 requested a review from brendandahl September 29, 2025 22:20
@sbc100 sbc100 requested a review from dschuff September 29, 2025 22:25
@brendandahl
Copy link
Collaborator

brendandahl commented Sep 29, 2025 •
edited
Loading

I think we need val.h updated too. Alternatively, add the asserts in wire.h which is included in both.

@sbc100
Copy link
Collaborator Author

sbc100 commented Sep 29, 2025

I think we need val.h updated too. Alternatively, add the asserts in wire.h which is included in both.

Done!

@sbc100 sbc100 enabled auto-merge (squash) September 29, 2025 23:15
@sbc100 sbc100 merged commit 88a8d74 into emscripten-core:main Sep 30, 2025
33 checks passed
@sbc100 sbc100 deleted the embind branch September 30, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandahl brendandahl brendandahl approved these changes

@dschuff dschuff Awaiting requested review from dschuff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @brendandahl