Separate out multithreading tests in browser harness #25459
Conversation
|
Closing in favor of #25469 |
|
Reopening given the feedback in #25467 (comment) |
There was a problem hiding this comment.
The actually non-test change here seems specific to file_packager. Perhaps you could mention that in the PR title? Its only not specific to FF, right? How about something like: "Avoid ES6 constructs in file_packager output"?
Its kind of a shame the file packager output often is covered by babel since its embedded in the generated code, but we also have the standalone mode.
Can you added a standalone file packager test to the test-node-compat and confirm that it fails before and after this PR with the oldest support node version (12.22.9).
juj
changed the title
I don't have Node.js 12, and working on ensuring the browser suite works on Node.js 12 seems like a separate pile of work. I'm verifying these PRs on Firefox atm, and that is already enough to get my table full. |
juj
force-pushed
the
firefox_78_esr_fixes
branch
from
85589af to
b5ccee9
Compare
Ok, I'll split out of the file_packager stuff maybe, and you can land the FF browser test stuff here. |
This allows the generated code to run on older engines. Unlike the majority of the emscripten-generated code the file packager output does not always get run through babel when targeting older engines. Specifically tests the standalone file packages code on the oldest support node version. This also required removing the use of the `fs/Promises` packages which is not present in older versions of node. Split out from emscripten-core#25459
This allows the generated code to run on older engines. Unlike the majority of the emscripten-generated code the file packager output does not always get run through babel when targeting older engines. Specifically tests the standalone file packages code on the oldest support node version. This also required removing the use of the `fs/Promises` packages which is not present in older versions of node. Split out from emscripten-core#25459
This allows the generated code to run on older engines. Unlike the majority of the emscripten-generated code the file packager output does not always get run through babel when targeting older engines. Specifically tests the standalone file packages code on the oldest support node version. This also required removing the use of the `fs/Promises` packages which is not present in older versions of node. Split out from emscripten-core#25459
This allows the generated code to run on older engines. Unlike the majority of the emscripten-generated code the file packager output does not always get run through babel when targeting older engines. Specifically tests the standalone file packages code on the oldest support node version. This also required removing the use of the `fs/Promises` packages which is not present in older versions of node. Split out from emscripten-core#25459
This allows the generated code to run on older engines. Unlike the majority of the emscripten-generated code the file packager output does not always get run through babel when targeting older engines. Specifically tests the standalone file packages code on the oldest support node version. This also required removing the use of the `fs/Promises` packages which is not present in older versions of node. Split out from emscripten-core#25459
…in them, or have be annotated with @requires_shared_array_buffer decorator.
juj
force-pushed
the
firefox_78_esr_fixes
branch
from
b5ccee9 to
29506cf
Compare
juj
changed the title
juj
force-pushed
the
firefox_78_esr_fixes
branch
from
640411f to
29b5adc
Compare
|
Ok, updated with the browser suite reorganization bits. |
This allows the generated code to run on older engines. Unlike the majority of the emscripten-generated code the file packager output does not always get run through babel when targeting older engines. Specifically tests the standalone file packages code on the oldest support node version. This also required removing the use of the `fs/Promises` packages which is not present in older versions of node. Split out from emscripten-core#25459
This allows the generated code to run on older engines. Unlike the majority of the emscripten-generated code the file packager output does not always get run through babel when targeting older engines. Specifically tests the standalone file packages code on the oldest support node version. This also required removing the use of the `fs/Promises` packages which is not present in older versions of node. Split out from #25459
Annotate browser tests that require SAB by attribute, or renaming test to have word 'thread' in it.