Skip to content

Conversation

brendandahl
Copy link
Collaborator

This test seems to flake a lot from this assertion. The fps on my machine often is only 20 fps, so I think when there are multiple browsers running the fps will be pretty low on CI.

@brendandahl brendandahl requested review from sbc100 and juj October 2, 2025 00:20
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment here about why we are being so conservative (i.e. mutliple browsers).

This test seems to flake a lot from this assertion. The fps on my
machine often is only 20 fps, so I think when there are multiple browsers
running the fps will be pretty low.
@brendandahl brendandahl merged commit 9c04c53 into emscripten-core:main Oct 2, 2025
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants