Skip to content

Add @requires_growable_arraybuffers decoration #25470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2025
Merged

Add @requires_growable_arraybuffers decoration #25470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98ee02b
Add requires_growable_arraybuffers decoration
juj Oct 2, 2025
bece798
Update circleci config
juj Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1096,6 +1096,8 @@ jobs:
test_targets: "browser64_4gb"
test-browser-firefox:
executor: focal
environment:
EMTEST_LACKS_GROWABLE_ARRAYBUFFERS: "1"
steps:
- prepare-for-tests
- run-tests-firefox:
Expand All @@ -1116,7 +1118,6 @@ jobs:
skip:browser.test_webgl_offscreen_canvas_in_pthread
skip:browser.test_webgl_offscreen_canvas_in_mainthread_after_pthread
skip:browser.test_glut_glutget
skip:browser.test_*_growable_arraybuffers
"
test-browser-firefox-wasm64:
executor: focal
Expand Down
3 changes: 3 additions & 0 deletions test/test_browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ def webgpu_disabled():
requires_sound_hardware = skipExecIf(os.getenv('EMTEST_LACKS_SOUND_HARDWARE'), 'This test requires sound hardware')
requires_offscreen_canvas = unittest.skipIf(os.getenv('EMTEST_LACKS_OFFSCREEN_CANVAS'), 'This test requires a browser with OffscreenCanvas')
requires_es6_workers = unittest.skipIf(os.getenv('EMTEST_LACKS_ES6_WORKERS'), 'This test requires a browser with ES6 Module Workers support')
requires_growable_arraybuffers = unittest.skipIf(os.getenv('EMTEST_LACKS_GROWABLE_ARRAYBUFFERS'), 'This test requires a browser that supports growable ArrayBuffers')


class browser(BrowserCore):
Expand Down Expand Up @@ -4685,6 +4686,7 @@ def test_minimal_runtime_hello_thread(self, opts):
})
@no_2gb('uses INITIAL_MEMORY')
@no_4gb('uses INITIAL_MEMORY')
@requires_growable_arraybuffers
def test_pthread_growth_mainthread(self, cflags, pthread_pool_size):
self.set_setting('PTHREAD_POOL_SIZE', pthread_pool_size)
if '-sGROWABLE_ARRAYBUFFERS' not in cflags:
Expand All @@ -4701,6 +4703,7 @@ def test_pthread_growth_mainthread(self, cflags, pthread_pool_size):
})
@no_2gb('uses INITIAL_MEMORY')
@no_4gb('uses INITIAL_MEMORY')
@requires_growable_arraybuffers
def test_pthread_growth(self, cflags, pthread_pool_size = 1):
self.set_setting('PTHREAD_POOL_SIZE', pthread_pool_size)
if '-sGROWABLE_ARRAYBUFFERS' not in cflags:
Expand Down