Skip to content

Remove double-logging of sub-commands. NFC #25478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
+3 −3
Merged

Remove double-logging of sub-commands. NFC #25478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tools/building.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,8 +378,8 @@ def acorn_optimizer(filename, passes, extra_info=None, return_output=False, work
if settings.VERBOSE:
cmd += ['--verbose']
if return_output:
shared.print_compiler_stage(cmd)
if shared.SKIP_SUBPROCS:
shared.print_compiler_stage(cmd)
return ''
return check_call(cmd, stdout=PIPE).stdout

Expand All @@ -390,8 +390,8 @@ def acorn_optimizer(filename, passes, extra_info=None, return_output=False, work
output_file = basename + '.jso%d.js' % acorn_optimizer.counter
shared.get_temp_files().note(output_file)
cmd += ['-o', output_file]
shared.print_compiler_stage(cmd)
if shared.SKIP_SUBPROCS:
shared.print_compiler_stage(cmd)
return output_file
check_call(cmd)
save_intermediate(output_file, '%s.js' % passes[0])
Expand Down Expand Up @@ -1245,8 +1245,8 @@ def run_binaryen_command(tool, infile, outfile=None, args=None, debug=False, std
if settings.GENERATE_SOURCE_MAP and outfile and tool in ['wasm-opt', 'wasm-emscripten-finalize', 'wasm-metadce']:
cmd += [f'--input-source-map={infile}.map']
cmd += [f'--output-source-map={outfile}.map']
shared.print_compiler_stage(cmd)
if shared.SKIP_SUBPROCS:
shared.print_compiler_stage(cmd)
return ''
ret = check_call(cmd, stdout=stdout).stdout
if outfile:
Expand Down