-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Bump min Firefox version to 68 ESR #25493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a block on line 862 of libwebgl.js
that can be deleted now too.
Otherwise lgtm
ChangeLog.md
Outdated
- Chrome: v70 -> v74 | ||
- Firefox: v55 -> v65 | ||
- Minimum Firefox version was further bumped up to Firefox 68 ESR - older | ||
Firefox versions are not able to run the parallel browser harness (#25493) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe delete the line above (and use the same "Firefox: X -> Y" format as the above bumps)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting Firefox: v55 -> v65
would lose the info on which version of Firefox added the globalThis
polyfill. I think having a mention of that in the ChangeLog is valuable, since it validates that Firefox is known to unconditionally also support it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm % changelog entry
context.defaultFboForbidBlitFramebuffer = firefoxVersion < 67; | ||
} | ||
} | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kind of change always makes me happy!
Firefox 66 and older are unable to run the parallel test harness.