Add/customizable file ending #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also threw in the ability to specify an input folder since it makes testing this against our final project way easier 😄 |
|
....and an ability to prefix things since we need to go back up a directory. 😛 |
eneko
approved these changes
Jul 22, 2019
|
Thank you for the PR, @designatednerd ! Really appreciate the update. |
|
Awesome! @eneko Can you please ping me when the update is pushed to Homebrew so I can delete some workaround instructions from my docs? |
|
BTW our docs generated with this are now live if you wanna see 'em. 😃 |
|
@designatednerd Sorry for the delay, I'm prepping a 0.6.0 release, hope to have it on Homebrew soon. Meanwhile, please use Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks so much for this project, it's super awesome. I'm using it to generate markdown-based documentation for apollo-ios since we've already got a theme that can generate HTML pages based on Markdown. The only issue is when that theme sees
.mdat the end of a link, it links directly to the markdown file rather than to the generated HTML page.This PR adds the ability to customize the text at the end of a link in the
README- in our case, switching to/instead of.mdleads to the desired behavior, but in other cases someone might want.htmlinstead. This change retains existing behavior of using.mdas a link ending by default.I also committed changes which were automatically applied to
Package.lockwhen usingswift run- let me know if you want me to revert that one, but it does not appear to have had any adverse affects.Enhancements
--link-endingparameter so that links inREADME.mdindex can be customized.