Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate when data was last added for country/radar #48

Closed
peterdesmet opened this issue Jan 12, 2018 · 12 comments
Closed

Indicate when data was last added for country/radar #48

peterdesmet opened this issue Jan 12, 2018 · 12 comments
Assignees

Comments

@peterdesmet
Copy link
Member

peterdesmet commented Jan 12, 2018

By @adokter:

@stijnvanhoey @peterdesmet Since a few days the data seem to flowing in again, maybe something broke in Sweden which was solved when people got back from Christmas.

Without any doubt such hickups will happen more often in the future. It would be good if we could see relatively quickly when certain radars stop providing data. A crude but simple solution would be if next to each country folder and radar folder the date of latest addition would be shown at http://enram.github.io/data-repository/. Is that a tweak that could be made before the start of this spring migration season (Mar 1), or does that require a real project?

@peterdesmet
Copy link
Member Author

You mean adding a last modified date like this?

screen shot 2018-01-12 at 12 15 39

Unfortunately, directories are not objects (with properties) in S3, so we can't add a property like last modified. As mentioned in this stackoverflow we'd need to keep our own log file to have that kind of information. Since we upload daily, we could have an automatically updated file radars.csv in the root with:

bejab 2018-01-01
bewid 2017-12-06
...

Would that be sufficient?

@adokter
Copy link
Contributor

adokter commented Jan 12, 2018

Yes filling out your red box is what I meant. But one file with latest modification date for each radar would be good enough too.

@peterdesmet
Copy link
Member Author

I'll let @stijnvanhoey answer what deadline is possible for creating (and updating) such a file. 😊

@stijnvanhoey
Copy link
Contributor

I can quickly provide the following information:

  • Not last modified (as this can be an historical file due to manual update/changes), but just the file with the most recent date in the filename.
  • integration with the coverage action: coverage AND most recent file is deduced (looping once over the entire bucket)

@peterdesmet any preference in file naming? most_recent.csv?

@stijnvanhoey
Copy link
Contributor

stijnvanhoey commented Jan 15, 2018

The code to create a file radars.csv is integrated with the coverage procedure. Needs further testing and will be available asap. The file looks as follows:

countryradar,datetime
bejab,2016-10-09 23:50
bewid,2018-01-13 17:00
bezav,2016-10-09 23:50
bgvar,2016-10-09 23:55
ctcdv,2016-10-09 23:56
ctpda,2016-10-09 23:56
czbrd,2016-10-09 23:45
czska,2016-10-09 23:45
deboo,2018-01-15 07:30
...

First version of the file uploaded with the library (not yet the pipeline): check http://enram.github.io/data-repository/

@stijnvanhoey
Copy link
Contributor

stijnvanhoey commented Jan 16, 2018

The creation of the radars.csv file is part of the daily data pipeline as well and running as required. We can later extend the functionality (automatic alerts,...), but closing this topic for now.

@adokter
Copy link
Contributor

adokter commented Jan 16, 2018

thanks for sorting this out so quickly!

@peterdesmet
Copy link
Member Author

Nice! Would maybe update header datetime to datetime_latest_data?

stijnvanhoey added a commit that referenced this issue Jan 16, 2018
stijnvanhoey added a commit that referenced this issue Jan 16, 2018
@plieper
Copy link
Contributor

plieper commented Mar 23, 2018

Hi guys,

I had a look at the repo to see if data is coming in regularly. The coverage.csv does come in handy then. One question though: what is the number you get in the column vp_files? The total number of vp's for the last day data was transferred? Or the total number of vp's that's available on the repo for that radar?

@adokter
Copy link
Contributor

adokter commented Mar 23, 2018

it's by day

@peterdesmet
Copy link
Member Author

Pretty sure it is the number of vp files for that date.

@plieper
Copy link
Contributor

plieper commented Mar 23, 2018

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants