Reintroduce header guards for IMGUI_DEFINE_MATH_OPERATORS to fix compiler warnings
#546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 33c5a96 removed the definition for
IMGUI_DEFINE_MATH_OPERATORSincluding a header guard fromimplot_internal.hand moved it into the unit filesimplot.cppandimplot_items.cppbut without a corresponding check whetherIMGUI_DEFINE_MATH_OPERATORSwas already defined.When
IMGUI_DEFINE_MATH_OPERATORSis set externally, e.g. via target compile definitions, this now leads to compiler warnings. The PR fixes these compiler warnings by reintroducing header guards forIMGUI_DEFINE_MATH_OPERATORS.