Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 122: Check family input valid #144

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Issue 122: Check family input valid #144

merged 4 commits into from
Jul 11, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Jul 11, 2024

Description

This PR closes #122.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes requested a review from seabbs July 11, 2024 09:46
seabbs
seabbs previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seabbs seabbs added this pull request to the merge queue Jul 11, 2024
@seabbs seabbs removed this pull request from the merge queue due to a manual request Jul 11, 2024
@seabbs seabbs enabled auto-merge July 11, 2024 10:44
@athowes athowes requested a review from seabbs July 11, 2024 11:50
@seabbs seabbs added this pull request to the merge queue Jul 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 11, 2024
@seabbs seabbs added this pull request to the merge queue Jul 11, 2024
@seabbs seabbs removed this pull request from the merge queue due to a manual request Jul 11, 2024
@seabbs seabbs merged commit 476c36e into main Jul 11, 2024
8 checks passed
@seabbs seabbs deleted the check-family branch July 11, 2024 14:42
seabbs pushed a commit that referenced this pull request Jan 10, 2025
@athowes
Issue 122: Check family input valid (#144)
f20f38c 
      * Add string and LPDF checker for epidist_family

* Add unit tests

* Correct the namespace handling

* Remove whitespace
  

Former-commit-id: ee4875ba9ef00ce9638eb43356910c34771bc338 [formerly 7662528d038aaba3b693984e255a0eff710eb35b]
Former-commit-id: 3b5a249b328b4ab61ff6dc3e2bf6391e97beae46
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 122: Check family input valid (#144)
b251228 
      * Add string and LPDF checker for epidist_family

* Add unit tests

* Correct the namespace handling

* Remove whitespace
  

Former-commit-id: 476c36e
Former-commit-id: c3a6719f79acbbf169e82dc0a03ffef93e2ee23d
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 122: Check family input valid (#144)
c1cd54d 
      * Add string and LPDF checker for epidist_family

* Add unit tests

* Correct the namespace handling

* Remove whitespace
  

Former-commit-id: 476c36e
Former-commit-id: c3a6719f79acbbf169e82dc0a03ffef93e2ee23d
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 122: Check family input valid (#144)
ea7ec59 
      * Add string and LPDF checker for epidist_family

* Add unit tests

* Correct the namespace handling

* Remove whitespace
  

Former-commit-id: 476c36e
Former-commit-id: c3a6719f79acbbf169e82dc0a03ffef93e2ee23d
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 122: Check family input valid (#144)
3987a52 
      * Add string and LPDF checker for epidist_family

* Add unit tests

* Correct the namespace handling

* Remove whitespace
  

Former-commit-id: ee4875ba9ef00ce9638eb43356910c34771bc338 [formerly 7662528d038aaba3b693984e255a0eff710eb35b]
Former-commit-id: 3b5a249b328b4ab61ff6dc3e2bf6391e97beae46
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 122: Check family input valid (#144)
4f112bc 
      * Add string and LPDF checker for epidist_family

* Add unit tests

* Correct the namespace handling

* Remove whitespace
  

Former-commit-id: ee4875ba9ef00ce9638eb43356910c34771bc338 [formerly 7662528d038aaba3b693984e255a0eff710eb35b]
Former-commit-id: 3b5a249b328b4ab61ff6dc3e2bf6391e97beae46
Former-commit-id: 3987a52
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 122: Check family input valid (#144)
58221f3 
      * Add string and LPDF checker for epidist_family

* Add unit tests

* Correct the namespace handling

* Remove whitespace
  

Former-commit-id: 476c36e
Former-commit-id: c3a6719f79acbbf169e82dc0a03ffef93e2ee23d
Former-commit-id: 5ccb76f6031c2bfe9c01bc3db7a466778435739f [formerly ea7ec59]
Former-commit-id: 8aeb79699e9966c979f96075f20b0c20629c35f0
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 122: Check family input valid (#144)
71fee5d 
      * Add string and LPDF checker for epidist_family

* Add unit tests

* Correct the namespace handling

* Remove whitespace
  

Former-commit-id: 476c36e
Former-commit-id: c3a6719f79acbbf169e82dc0a03ffef93e2ee23d
Former-commit-id: 5ccb76f6031c2bfe9c01bc3db7a466778435739f [formerly ea7ec59]
Former-commit-id: 8aeb79699e9966c979f96075f20b0c20629c35f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checking family argument
2 participants
@athowes @seabbs