Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock in current dependencies for the driver #33

Closed
wants to merge 1 commit into from

Conversation

benjamb
Copy link
Contributor

@benjamb benjamb commented Nov 16, 2018

The packngo API has changed, resulting in build failures in fresh source
checkouts. Makes use of the opt-in modules[1] in Go 1.11 to lock
dependencies to the latest, except packngo, which is locked down at
commit 4099eefca4977c9a4909da715fa11055cdcf43c6, which is prior to the
Facility type change.

[1] https://github.com/golang/go/wiki/Modules

Fixes #32.

The packngo API has changed, resulting in build failures in fresh source
checkouts. Makes use of the opt-in modules[1] in Go 1.11 to lock
dependencies to the latest, except packngo, which is locked down at
commit 4099eefca4977c9a4909da715fa11055cdcf43c6, which is prior to the
Facility type change.

[1] https://github.com/golang/go/wiki/Modules
pdiaz added a commit to pdiaz/docker-machine-driver-packet that referenced this pull request Jan 17, 2019
@mmlb mmlb mentioned this pull request Jan 31, 2019
@jasmingacic
Copy link
Contributor

PR #41 will introduce Go modules and this will be addressed with it.

@jasmingacic jasmingacic closed this Aug 9, 2019
@benjamb benjamb deleted the deps branch August 3, 2020 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facility String Compile Error
2 participants