Enable message of the day #140
Conversation
ManInFez
force-pushed
the
motd
branch
5 times, most recently
from
2296d98
to
7c83ba6
Compare
|
This is really good. I think it's better if the script goes over every release in If this script goes over every release, then we'll be able to do things like apply messages to A rule like the following should apply to For a rule like could match both |
|
Also, do we want to have messages inline in the YAML file? It'll cut down on the number of files in git for trivial messages. |
ManInFez
force-pushed
the
motd
branch
2 times, most recently
from
5875d3e
to
45a6a91
Compare
| "--komodo-prefix", | ||
| "-k", | ||
| required=True, | ||
| help="Path to folder holding komodo-releases.", |
There was a problem hiding this comment.
Ambiguous: Path to https://github.com/equinor/komodo-releases or /prog/res/komodo? Perhaps "Path to komodo releases root (eg. /prog/res/komodo)". Also make it the default.
komodo/post_messages.py
Outdated
| scripts = ( | ||
| scripts + motd_db[key].get("scripts") | ||
| if motd_db[key].get("scripts") is not None | ||
| else scripts | ||
| ) |
There was a problem hiding this comment.
scripts.extend(motd_db[key].get("scripts", []))?
komodo/post_messages.py
Outdated
|
|
||
|
|
||
| def copy_files(file_list, dst_path, src_path): | ||
| if os.path.isdir(dst_path): |
There was a problem hiding this comment.
should not happen, as they are cleared in the beginning
komodo/post_messages.py
Outdated
|
|
||
|
|
||
| def create_inline_messages(messages, clear_old_messages, dst_path): | ||
| if clear_old_messages: |
There was a problem hiding this comment.
should not happen, as they are cleared in the beginning
ManInFez
force-pushed
the
motd
branch
2 times, most recently
from
72c0704
to
5f098b4
Compare
resolves equinor/ert#735
depends on https://github.com/equinor/komodo-releases/pull/620