Skip to content

feat: support explicit LogGroupName #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 23, 2022
Merged

feat: support explicit LogGroupName #449

merged 4 commits into from
Jan 23, 2022

Conversation

@erezrokah
Copy link
Owner

@erezrokah erezrokah commented Aug 21, 2021

Fixes #348

@coveralls
Copy link

coveralls commented Aug 21, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1736693992

  • 9 of 9 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 99.725%
Totals Coverage Status
Change from base Build 1736693612: -0.3%
Covered Lines: 604
Relevant Lines: 604
💛 - Coveralls

@jakejscott
Copy link

jakejscott commented Sep 10, 2021

@erezrokah Thanks for adding this, will it be released soon?

@erezrokah erezrokah force-pushed the feat/log_group_name branch from 472ba61 to 46a3cdc Compare January 23, 2022 17:47
@erezrokah erezrokah marked this pull request as ready for review January 23, 2022 18:03
@erezrokah erezrokah merged commit 8dceeaa into main Jan 23, 2022
@erezrokah erezrokah deleted the feat/log_group_name branch January 23, 2022 18:58
@erezrokah erezrokah mentioned this pull request Jan 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Explicit LogGroupName in toHaveLog() function

4 participants

@erezrokah @coveralls @jakejscott