add git clone --reference path support #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferd
reviewed
Jul 26, 2018
src/rebar_git_resource.erl
Outdated
| git_clone_options() -> | ||
| Option = case os:getenv("REBAR_GIT_CLONE_OPTIONS") of | ||
| false -> "" ; %% env var not set | ||
| [] -> "" ; %% env var set to empty |
There was a problem hiding this comment.
this clause would be covered fine under Opt -> Opt
There was a problem hiding this comment.
Sorry, I did not get your point. Could you explain it with more detail?
Thx.
There was a problem hiding this comment.
[] -> "" basically means "" -> "" which the clause Opt -> Opt would catch anyway
There was a problem hiding this comment.
I see.
[] and "" render the same result for io:format("...~ts...").
|
could anyone merge this patch to master? |
|
I think I'm good with this, and since it's optional for now it's rather risk-free. @tsloughter agreeing? |
ferd
approved these changes
Nov 13, 2018
|
Yea. |
|
Thanks for the contribution, @simonxu72 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run rebar3 upgrade on multiple projects, most git clone for common deps are identical. So I add git clone --reference support.
Howto:
1.setup a enviroment variable REBAR_GIT_CLONE_OPTONS
export REBAR_GIT_CLONE_OPTIONS="--reference ~/.cache/repos.reference"
2.build a git local repos reference
mkdir -p ~/.cache/repos.reference
cd ~/.cache/repos.reference
git init --bare
git remote add lager https://github.com/.......
git remote add otp_vsn https://github.com/....
< all you deps share in all projects can be added here... not only in github...>
git fetch --all
3.build local new rebar3 version has this patch
git clone https://github.com/simonxu72/rebar3
cd ~/rebar3
./bootstrap
./rebar3 local install
4.rebar3 upgrade in your project.All git clone operation will be local