-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make separate dependencies rules #89
base: master
Are you sure you want to change the base?
Conversation
Q: How can I check that my changes don't break the TASTE build ? |
The TASTE builds have their own CI on gitlab. Passing the CI here on Github is sufficient |
Makefile
Outdated
@@ -58,25 +58,24 @@ update: | |||
/tmp/antlr3_python3_runtime_3.4: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This path is temporary and cleaned up on reboot. Why don't you check for a file where the antlr runtime has actually been installed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, that would be better...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, turns out it only install python libraries, no binary, so the location would depend on the virtualenv setup and the python version used... I might take the option to download and extract in the working directory to avoid multiple downloads... until all pip requirements are managed directly via python/pip.
python3 -m pip install --user --upgrade pyside6 pygraphviz stringtemplate3 singledispatch | ||
|
||
dependencies: ~/.local/bin/asn1scc | ||
sudo apt install -y python3 python3-pip libgl1 gnat python3-pexpect graphviz libgraphviz-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have you replaced python3-pygraphviz
with graphviz
+ libgraphviz-dev
+ pygraphviz
from pip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If pygraphviz
is a dependency of opengeode
, it should be installed when opengeode
is installed (via pip in the perspective of opengeode being installed as any python package).
Therefore I rely on pygraphviz
from pip.
The installer of pygraphviz
will detect if the appropriate graphviz
libraries are installed on the machine, so I let pygraphviz
deal with its dependencies. Ref: https://pygraphviz.github.io/documentation/stable/install.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that's good for me (I tried it, it works)
FYI I am planning to merge the recent master in this branch. I haven't looked at it in a while, and I want to make sure everything still works fine with version 4.0. Hopefully sometime in the next few days. |
Everything looks fine, I merged master in this branch, and did an install again:
(newlines added for readability) And running opengeode opens the GUI. |
This PR is only about having separate makefile rules for the different dependencies.
It will be simpler to deal with them separately in a subsequent PR.