Skip to content

fix: enforce valid allow* values in prefer-logical-properties rule #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

fix: enforce valid allow* values in prefer-logical-properties rule #311

merged 1 commit into from
Oct 27, 2025

Conversation

@thecalamiity
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

This PR updates the prefer-logical-properties rule to enforce that the allowProperties and allowUnits options only accept valid, known CSS properties and units. Previously, invalid values were silently ignored.

What changes did you make? (Give an overview)

  • Updated the rule schema so allowProperties and allowUnits only accept values present in propertiesReplacements and unitReplacements.
  • Updated documentation with usage examples for both options.
  • Corrected uniqueItems: true placement in relative-font-units schema.

Related Issues

Fixes #303

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Oct 27, 2025
@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Oct 27, 2025
@eslint-github-bot eslint-github-bot bot mentioned this pull request Oct 27, 2025
Closed
1 task
@Tanujkanti4441 Tanujkanti4441 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Oct 27, 2025
@Tanujkanti4441 Tanujkanti4441 moved this from Needs Triage to Implementing in Triage Oct 27, 2025
Tanujkanti4441
Tanujkanti4441 approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@Tanujkanti4441 Tanujkanti4441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Would like another review on this.

@Tanujkanti4441 Tanujkanti4441 moved this from Implementing to Second Review Needed in Triage Oct 27, 2025
nzakas
nzakas approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 23caee3 into eslint:main Oct 27, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Oct 27, 2025
@github-actions github-actions bot mentioned this pull request Oct 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nzakas nzakas nzakas approved these changes

@Tanujkanti4441 Tanujkanti4441 Tanujkanti4441 approved these changes

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion bug Something isn't working contributor pool

Projects

Triage
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rule Change: Restrict allowProperties and allowUnits options to known values

3 participants

@thecalamiity @nzakas @Tanujkanti4441