Fix: include loadRules in internalSlotsMap cache (#19)

* Fix: include loadRules in internalSlotsMap cache * add unit test
eslint · Dec 3, 2020 · 1746840 · 1746840
1 parent f30bb49
commit 1746840
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/cascading-config-array-factory.js b/lib/cascading-config-array-factory.js
@@ -256,7 +256,8 @@ class CascadingConfigArrayFactory {
             rulePaths,
             specificConfigPath,
             useEslintrc,
-            builtInRules
+            builtInRules,
+            loadRules
         });
     }
 

diff --git a/tests/lib/cascading-config-array-factory.js b/tests/lib/cascading-config-array-factory.js
@@ -1893,4 +1893,22 @@ describe("CascadingConfigArrayFactory", () => {
             });
         });
     });
+
+    describe("bug fixes", () => {
+        /*
+         * Clearing cache would previously error on 'createBaseConfigArray()' call
+         * with 'TypeError: loadRules is not a function'
+         * https://github.com/eslint/eslintrc/pull/19
+         */
+        it("should not error when 'clearCache()' is called with `rulePaths` and 'loadRules' options provided.", () => {
+            const factory = new CascadingConfigArrayFactory({
+                rulePaths: ["./rules"],
+                loadRules() {
+                    return [];
+                },
+            });
+
+            factory.clearCache();
+        });
+    });
 });