Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Update Default Ignore Patterns #51

Merged
merged 3 commits into from
Jan 6, 2020

Conversation

mysticatea
Copy link
Member

Summary

This proposal changes the default ignore patterns to include the node_modules of subdirectories and to exclude .eslintrc.js.

Related Issues

@mysticatea mysticatea added Initial Commenting This RFC is in the initial feedback stage breaking change This RFC contains breaking changes labels Nov 28, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! LGTM.

@mysticatea
Copy link
Member Author

I have updated this proposal to stop ignoring /bower_components/*, as following the decision in the last TSC meeting.

@mysticatea mysticatea added Final Commenting This RFC is in the final week of commenting and removed Initial Commenting This RFC is in the initial feedback stage labels Dec 20, 2019
@mysticatea mysticatea merged commit e846a14 into master Jan 6, 2020
@mysticatea mysticatea deleted the update-default-ignore-patterns branch January 6, 2020 10:24
mysticatea added a commit to eslint/eslint that referenced this pull request Feb 8, 2020
mysticatea added a commit to eslint/eslint that referenced this pull request Feb 8, 2020
btmills pushed a commit to eslint/eslint that referenced this pull request Feb 14, 2020
montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This RFC contains breaking changes Final Commenting This RFC is in the final week of commenting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants