tests(wifi): Fix argument passing

Author: lucasssvaz

.github/scripts/tests_run.sh

@@ -92,7 +92,6 @@ function run_test {
             if [[ -f "$sketchdir/diagram.$target.json" ]]; then
                 extra_args+=("--wokwi-diagram" "$sketchdir/diagram.$target.json")
             fi
-
         elif [ $platform == "qemu" ]; then
             PATH=$HOME/qemu/bin:$PATH
             extra_args=("--embedded-services" "qemu" "--qemu-image-path" "$build_dir/$sketchname.ino.merged.bin")
@@ -161,7 +160,6 @@ while [ -n "$1" ]; do
         platform="qemu"
         ;;
     -W )
-        shift
         if [[ -z $WOKWI_CLI_TOKEN ]]; then
             echo "Wokwi CLI token is not set"
             exit 1

.gitlab/workflows/hw_test_template.yml

@@ -12,13 +12,13 @@ include:
 hw-test-template:
   stage: test
   image: python:3.12-bookworm
+  timeout: 5h
 
   rules:
     - when: on_success
 
   variables:
     RUNNER_SCRIPT_TIMEOUT: 4h
-    RUNNER_AFTER_SCRIPT_TIMEOUT: 2h
     DEBIAN_FRONTEND: "noninteractive"
     TEST_TYPE: $TEST_TYPE
     TEST_CHIP: $TEST_CHIP

tests/validation/wifi/test_wifi.py

@@ -15,11 +15,11 @@ def test_wifi(dut, wifi_ssid, wifi_pass):
 
     dut.expect_exact("Send SSID:")
     LOGGER.info(f"Sending WiFi credentials: SSID={wifi_ssid}")
-    dut.write(f"{wifi_ssid}")
+    dut.write(f"{wifi_ssid}\n")
 
     dut.expect_exact("Send Password:")
     LOGGER.info(f"Sending WiFi password: Password={wifi_pass}")
-    dut.write(f"{wifi_pass or ''}")
+    dut.write(f"{wifi_pass or ''}\n")
 
     # Verify credentials were received
     dut.expect_exact(f"SSID: {wifi_ssid}")

tests/validation/wifi/wifi.ino

@@ -89,6 +89,12 @@ void WiFiGotIP(WiFiEvent_t event, WiFiEventInfo_t info) {
 
 void readWiFiCredentials() {
   Serial.println("Waiting for WiFi credentials...");
+
+  // Flush any existing data in serial buffer
+  while (Serial.available()) {
+    Serial.read();
+  }
+
   Serial.println("Send SSID:");
 
   // Wait for SSID
@@ -100,11 +106,17 @@ void readWiFiCredentials() {
     delay(100);
   }
 
+  // Flush any remaining data from SSID input
+  while (Serial.available()) {
+    Serial.read();
+  }
+
   Serial.println("Send Password:");
 
   // Wait for password (allow empty password)
   bool password_received = false;
-  while (!password_received) {
+  unsigned long timeout = millis() + 10000;  // 10 second timeout
+  while (!password_received && millis() < timeout) {
     if (Serial.available()) {
       password = Serial.readStringUntil('\n');
       password.trim();
@@ -113,6 +125,11 @@ void readWiFiCredentials() {
     delay(100);
   }
 
+  // Flush any remaining data
+  while (Serial.available()) {
+    Serial.read();
+  }
+
   Serial.print("SSID: ");
   Serial.println(ssid);
   Serial.print("Password: ");