You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The second one should be ESPRESSO_PROFILER_MARK_END. The regression was introduced in 1df1009. When calling these functions inside the body of a Python loop, the Caliper summary creates a recursive data structure for the marked region, since the end marker is missing.
The Cython interface passes Python string objects to C++ functions that take std::string as arguments, triggering runtime exceptions. The interface should use espressomd.utils.to_char_pointer() to handle type conversion. The regression was introduced in df5d9d2.
There are no test cases for this feature.
The text was updated successfully, but these errors were encountered:
Fixes#4740, fixes#2509
Description of changes:
- third-party tools:
- fix the broken Caliper integration and write an integration test
- use standard Caliper macros instead of macro aliases
- build Caliper as a CMake subproject to inherit options (e.g. CUDA and MPI support) and facilitate linking
- add native support for CUDA-GDB (a few compiler flags were missing from `Debug` builds)
- add native support for kernprof (new flag added to `pypresso`)
- documentation:
- centralize scattered information about debuggers into a self-contained section of the user guide
- document all supported debuggers and profilers: Caliper, Valgrind, GDB, CUDA-GDB, kernprof, perf, sanitizers
- make the Doxygen docs more consistent with the Sphinx user guide (same fonts) and website (same logo)
The Caliper bindings that mark the start and end of a portion of code to instrument are incorrect:
espresso/src/profiler/include/profiler/profiler.hpp
Lines 62 to 64 in 09c6958
espresso/src/profiler/include/profiler/profiler.hpp
Lines 71 to 73 in 09c6958
The second one should be
ESPRESSO_PROFILER_MARK_END
. The regression was introduced in 1df1009. When calling these functions inside the body of a Python loop, the Caliper summary creates a recursive data structure for the marked region, since the end marker is missing.The Cython interface passes Python string objects to C++ functions that take
std::string
as arguments, triggering runtime exceptions. The interface should useespressomd.utils.to_char_pointer()
to handle type conversion. The regression was introduced in df5d9d2.There are no test cases for this feature.
The text was updated successfully, but these errors were encountered: