Skip to content

Conversation

RKBoss6
Copy link
Contributor

@RKBoss6 RKBoss6 commented Sep 2, 2025

Uses HRM to detect sleep states rather than movement if HRM data is present. Also updated the settings page with 2 new submenus: HRM Thresholds, and Other Settings. HRM thresholds contains thresholds for HRM, and other settings contains the settings like BreakToD, Min time worn, wear temp, etc.

Still testing this, but it seems to work pretty well.

@RKBoss6 RKBoss6 marked this pull request as draft September 2, 2025 00:51
@bobrippling
Copy link
Collaborator

Nice idea, thanks - tagging @myxor if you wanted to check it out

@myxor
Copy link
Contributor

myxor commented Sep 2, 2025

Thanks for the tag @bobrippling but i can not check it out right now.
Maybe @halemmerich can have a look.

@thyttan
Copy link
Collaborator

thyttan commented Sep 2, 2025

I know you're not here always, but tagging @storm64 as the original creator.

@RKBoss6 RKBoss6 marked this pull request as ready for review September 4, 2025 21:59
@RKBoss6
Copy link
Contributor Author

RKBoss6 commented Sep 4, 2025

Tested, should the app show the difference between light sleep and deep sleep, or just purple?

@RKBoss6
Copy link
Contributor Author

RKBoss6 commented Sep 6, 2025

Nevermind, this is good to go!

@storm64
Copy link
Contributor

storm64 commented Sep 8, 2025

Sadly, I don't have the time to test it, but it looks like a good addition to the app.
On having a look at the changes, I could not find where the Settings for 'Max Awake' and 'Min Consecutive' went?

@bobrippling
Copy link
Collaborator

LGTM, if you could scoot that comment around, I'll merge :)

@RKBoss6
Copy link
Contributor Author

RKBoss6 commented Sep 8, 2025

Alright, just fixed it, thanks @storm64!

@bobrippling
Copy link
Collaborator

Nice, thanks!

@bobrippling bobrippling merged commit dc72216 into espruino:master Sep 10, 2025
1 check passed
@RKBoss6 RKBoss6 deleted the SleepLogHRM branch September 10, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants