Skip to content

[SleepLog] Fix thresholds not changing functionality #4010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2025
Merged

[SleepLog] Fix thresholds not changing functionality #4010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cdc0a9
Fix settings not changing threshold bug
RKBoss6 Sep 25, 2025
facd5b7
Update ChangeLog
RKBoss6 Sep 25, 2025
5ac416e
Update version and description in metadata.json
RKBoss6 Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/sleeplog/ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,4 @@
0.19: Write sleep state into health event's .activity field
0.20: Increase default sleep thresholds, tweak settings to allow higher ones to be chosen
0.21: Use HRM data is polling is enabled, and add appropriate thresholds in settings. Change settings to feel more intuitive, rather than copied settings in different pages.
0.22: Fix bug with HRM threshold not updating
4 changes: 2 additions & 2 deletions apps/sleeplog/boot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,9 @@ if (global.sleeplog.conf.enabled) {
if(data.hrm){

if (!Bangle.isCharging()) {
if (data.heartRate <= global.sleeplog.conf.hrDeepTh) {
if (data.heartRate <= global.sleeplog.conf.hrmDeepTh) {
data.status = 4; // deep sleep
} else if (data.heartRate <= global.sleeplog.conf.hrLightTh) {
} else if (data.heartRate <= global.sleeplog.conf.hrmLightTh) {
data.status = 3; // light sleep
} else {
data.status = 2; // awake
Expand Down
4 changes: 2 additions & 2 deletions apps/sleeplog/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"id":"sleeplog",
"name":"Sleep Log",
"shortName": "SleepLog",
"version": "0.21",
"description": "Log and view your sleeping habits. This app uses built in movement calculations, or HRM data is present. View data from Bangle, or from the web app.",
"version": "0.22",
"description": "Log and view your sleeping habits. This app uses built in movement calculations, or HRM data, if enabled. View data from Bangle.js, or from the web app.",
"icon": "app.png",
"type": "app",
"tags": "tool,boot,health",
Expand Down