Tries to upload non-existent weather and messages module

[thyttan]

Noticed in the Brave browser console output that the app loader tries to load weather and messagesmodule that doesn't exist. This was during an install of confthyttan default config. It didn't stop the collection of apps to be installed correctly.

So not a big problem.

Starting on line 7898 of confthyttan-upload-web-console.txt:

espruinotools.js:145 Loading modules
espruinotools.js:8828 loadModule(weather)
espruinotools.js:6783  GET https://espruino.github.io/BangleApps/modules/weather.min.js 404 (Not Found)

[...]

espruinotools.js:6783  GET https://espruino.github.io/BangleApps/modules/weather.js 404 (Not Found)

[...]

/BangleApps/?q=thy:1 Access to XMLHttpRequest at 'https://www.espruino.com/modules/weather.js' from origin 'https://espruino.github.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

line 1978:

 espruinotools.js:6783  GET https://espruino.github.io/BangleApps/modules/messages.js 404 (Not Found)

Some other ones:

Font7x11Numeric7Seg is not in the modules folder:

espruinotools.js:6772 getURL("https://espruino.github.io/BangleApps/modules/Font7x11Numeric7Seg.js") error : HTTP 404

Recorder:

espruinotools.js:6783  GET https://espruino.github.io/BangleApps/modules/recorder.js 404 (Not Found)

[gfwilliams]

As in #73 we don't know if a module's there unless we search for it.

... however in this case, I think maybe the app loader could look through the 'dependencies' list and add any modules it thinks are there to the preexisting modules list?

It seems we do try and do this for existing apps: https://github.com/espruino/EspruinoAppLoaderCore/blob/master/js/appinfo.js#L119-L132

So maybe something is wrong or the app list doesn't include the apps that have just been installed?

[thyttan]

What seemed weird to me was that it looked for messages, recorder and weather in the modules directory while they live in subdirectories of the apps directory.

[gfwilliams]

The modules that are provided by apps aren't actually loaded at upload time. The app with the module will install a file called recorder/etc on the Bangle, and when you require the Bangle loads that (rather than it being built into the app.js file)

The app loader was just searching for the module from the modules directory just in case - but hopefully now all that should have gone away

[thyttan]

Ok - thanks! 🙏