Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnaryExpression are always prefix #118

Closed
wants to merge 1 commit into from
Closed

Conversation

amasad
Copy link

@amasad amasad commented Jan 21, 2016

The prefix boolean field on UnaryExpressions is redundant because all operators are currently prefix.

The `prefix` boolean field on UnaryExpressions is redundant because all operators are currently prefix.
@ariya
Copy link
Contributor

ariya commented Jan 21, 2016

While it's likely harmless, doesn't this fall into "Non-additive modifications"?

@forivall
Copy link
Contributor

I'm speculating that it's so that UpdateExpression and UnaryExpressions can be handled by the same functions, or some other historical reason like a Mozilla js extension that added non-prefix unary expressions.

@RReverser
Copy link
Member

Yeah, we discussed this with @dherman and, unfortunately, this is one of redundant design decisions that were here from the beginning and thus breaking to remove.

@amasad
Copy link
Author

amasad commented Jan 21, 2016

Ok, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants