Disconnect from channel #107
Conversation
| @@ -110,7 +110,6 @@ +(void)nativeClose:(NSValue *)nativeTransport { | |||
| MSC_TRACE(); | |||
|
|
|||
| [TransportWrapper extractNativeTransport:nativeTransport]->Close(); | |||
| [nativeTransport release]; | |||
There was a problem hiding this comment.
hi @fedulvtubudul , I'm curious why is this not necessary.. when/where is it released instead?
not an expert btw but i've been using this library and faced some issues.
thanks!
There was a problem hiding this comment.
This fragment looks fragile. If user does not close the transport, the transport object will leak. If user will try to close the transport twice, app will crash while accessing already deallocated object.
With this change, app does not crash after leaving a channel (or ending a call). BUT yes, it has memory leaks, lots of them actually. I'm trying to solve the leaks, you can check the progress here: VLprojects@bb2295c, but it's not finished yet.
@pablito25sp replying to your answer, I believe each "native" object lifecycle should be bound to it's obj-c wrapper object lifecycle. So we should call new from init and free from dealloc. That should make library usage more safe.
This patch fixes the crash during an attempt to disconnect from a channel.
Related issues:
Currently I'm working on the memory leaks that are still there, but they are a bit harder to verify than the crash itself.